Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
2020-10-26 20:34:11
Also in
lkml
Reply to
Guenter Roeck, 2020-10-26
On Mon, Oct 26, 2020 at 12:41 PM Guenter Roeck [off-list ref] wrote:
make ARCH=um SUBARCH=x86_64 defconfig:

Building um:defconfig ... failed
--------------
Error log:
arch/um/kernel/skas/clone.c:24:16: error: expected declaration specifiers or '...' before string constant
arch/x86/um/stub_segv.c:11:16: error: expected declaration specifiers or '...' before string constant
Weird. Is __section() not defined somehow for those files?

It does look like they have very minimal headers, so undoing that
patch just for those two files is likely the right thing to do.
As with s390, reverting this patch fixes the problem.
s390 should be fixed already.

Is the attached minimal patch sufficient for um to get back to working
order, or is there something else hiding there too?

                   Linus

Attachments

Thread (11 messages) 11 messages, 6 authors, last reply 2020-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help