Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

From
Joe Perches <joe@perches.com>
Date
2020-10-23 08:03:24
Also in
lkml
Reply to
Miguel Ojeda, 2020-10-23
On Fri, 2020-10-23 at 08:08 +0200, Miguel Ojeda wrote:
On Thu, Oct 22, 2020 at 4:36 AM Joe Perches [off-list ref] wrote:
quoted
Use a more generic form for __section that requires quotes to avoid
complications with clang and gcc differences.
I performed visual inspection (one by one...) and the only thing I saw
is that sometimes the `__attribute__` has a whitespace afterwards and
sometimes it doesn't, same for the commas inside, e.g.:

-  __used __attribute__((section(".modinfo"), unused, aligned(1)))  \
+  __used __section(".modinfo") __attribute__((unused, aligned(1)))  \

and:

-    __attribute__ ((unused,__section__ ("__param"),aligned(sizeof(void *)))) \
+    __section("__param") __attribute__ ((unused, aligned(sizeof(void *)))) \

I think the patch tries to follow the style of the replaced line, but
for the commas in this last case it didn't. Anyway, it is not
important.
Here the change follows the kernel style of space after comma.
I can pick it up in my queue along with the __alias one and keep it
for a few weeks in -next.
Thanks Miguel, but IMO it doesn't need time in next.

Applying it just before an rc1 minimizes conflicts.

Thread (11 messages) 11 messages, 6 authors, last reply 2020-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help