Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

From
Guenter Roeck <linux@roeck-us.net>
Date
2020-10-26 19:36:57
Also in
lkml
Reply to
Joe Perches, 2020-10-22
On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote:
Use a more generic form for __section that requires quotes to avoid
complications with clang and gcc differences.

Remove the quote operator # from compiler_attributes.h __section macro.

Convert all unquoted __section(foo) uses to quoted __section("foo").
Also convert __attribute__((section("foo"))) uses to __section("foo")
even if the __attribute__ has multiple list entry forms.

Conversion done using a script:

Link: https://lore.kernel.org/lkml/75393e5ddc272dc7403de74d645e6c6e0f4e70eb.camel@perches.com/2-convert_section.pl (local)

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Nick Desaulniers <redacted>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
s390 (all builds):

Error log:
error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[2]: *** [arch/s390/boot/section_cmp.boot.preserved.data] Error 1
make[2]: *** Waiting for unfinished jobs....
error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1
make[1]: *** [bzImage] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [__sub-make] Error 2

Reverting this patch fixes the problem.

Guenter
Thread (11 messages) 11 messages, 6 authors, last reply 2020-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help