Thread (12 messages) 12 messages, 4 authors, 2019-07-02

Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions

From: Nicholas Piggin <npiggin@gmail.com>
Date: 2019-07-02 03:07:34
Also in: linux-arm-kernel, linux-mm

Will Deacon's on July 1, 2019 8:15 pm:
On Mon, Jul 01, 2019 at 11:03:51AM +0100, Steven Price wrote:
quoted
On 01/07/2019 10:27, Will Deacon wrote:
quoted
On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote:
quoted
walk_page_range() is going to be allowed to walk page tables other than
those of user space. For this it needs to know when it has reached a
'leaf' entry in the page tables. This information will be provided by the
p?d_large() functions/macros.
I can't remember whether or not I asked this before, but why not call
this macro p?d_leaf() if that's what it's identifying? "Large" and "huge"
are usually synonymous, so I find this naming needlessly confusing based
on this patch in isolation.
Those page table macro names are horrible. Large, huge, leaf, wtf?
They could do with a sensible renaming. But this series just follows
naming that's alreay there on x86.

Thanks,
Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help