Thread (19 messages) flat view 19 messages, 5 authors, 2018-10-04

Re: [PATCH v2 3/4] powerpc/tm: Adjust tm_reclaim_thread() parameters

From: Michael Neuling <hidden>
Date: 2018-08-16 11:57:50

On Mon, 2018-06-18 at 19:59 -0300, Breno Leitao wrote:
From: Cyril Bur <redacted>
=20
tm_reclaim_thread() doesn't use the parameter anymore, both callers have
to bother getting it as they have no need for a struct thread_info
either.
=20
It was previously used but became unused in commit
dc3106690b20 ("powerpc: tm: Always use fp_state and vr_state to store liv=
e
registers")
=20
Just remove it and adjust the callers.
=20
Signed-off-by: Cyril Bur <redacted>
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Michael Neuling <redacted>
quoted hunk ↗ jump to hunk
---
 arch/powerpc/kernel/process.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
=20
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.=
c
quoted hunk ↗ jump to hunk
index 9ef4aea9fffe..f8beee03f00a 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -866,8 +866,7 @@ static inline bool tm_enabled(struct task_struct *tsk=
)
quoted hunk ↗ jump to hunk
 	return tsk && tsk->thread.regs && (tsk->thread.regs->msr & MSR_TM);
 }
=20
-static void tm_reclaim_thread(struct thread_struct *thr,
-			      struct thread_info *ti, uint8_t cause)
+static void tm_reclaim_thread(struct thread_struct *thr, uint8_t cause)
 {
 	/*
 	 * Use the current MSR TM suspended bit to track if we have
@@ -914,7 +913,7 @@ static void tm_reclaim_thread(struct thread_struct *t=
hr,
quoted hunk ↗ jump to hunk
 void tm_reclaim_current(uint8_t cause)
 {
 	tm_enable();
-	tm_reclaim_thread(&current->thread, current_thread_info(), cause);
+	tm_reclaim_thread(&current->thread, cause);
 }
=20
 static inline void tm_reclaim_task(struct task_struct *tsk)
@@ -945,7 +944,7 @@ static inline void tm_reclaim_task(struct task_struct
*tsk)
 		 thr->regs->ccr, thr->regs->msr,
 		 thr->regs->trap);
=20
-	tm_reclaim_thread(thr, task_thread_info(tsk), TM_CAUSE_RESCHED);
+	tm_reclaim_thread(thr, TM_CAUSE_RESCHED);
=20
 	TM_DEBUG("--- tm_reclaim on pid %d complete\n",
 		 tsk->pid);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help