Thread (49 messages) 49 messages, 3 authors, 2018-07-17

Re: [PATCH v13 22/24] selftests/vm: testcases must restore pkey-permissions

From: Dave Hansen <hidden>
Date: 2018-06-20 15:20:25
Also in: linux-arch, linux-kselftest, linux-mm

On 06/13/2018 05:45 PM, Ram Pai wrote:
Generally the signal handler restores the state of the pkey register
before returning. However there are times when the read/write operation
can legitamely fail without invoking the signal handler.  Eg: A
sys_read() operaton to a write-protected page should be disallowed.  In
such a case the state of the pkey register is not restored to its
original state.  The test case is responsible for restoring the key
register state to its original value.
Seems fragile.  Can't we just do this in common code?  We could just
loop through and restore the default permissions.  That seems much more
resistant to a bad test case.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help