Re: [PATCH v13 16/24] selftests/vm: clear the bits in shadow reg when a pkey is freed.
From: Dave Hansen <hidden>
Date: 2018-06-20 15:07:34
Also in:
linux-arch, linux-kselftest, linux-mm
On 06/13/2018 05:45 PM, Ram Pai wrote:
quoted hunk ↗ jump to hunk
--- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c@@ -577,7 +577,8 @@ int sys_pkey_free(unsigned long pkey) int ret = syscall(SYS_pkey_free, pkey); if (!ret) - shadow_pkey_reg &= clear_pkey_flags(pkey, PKEY_DISABLE_ACCESS); + shadow_pkey_reg &= clear_pkey_flags(pkey, + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); return ret; }
Why did you introduce this code earlier and then modify it now? BTW, my original aversion to this code still stands.