Thread (83 messages) flat view 83 messages, 6 authors, 2018-03-27

Re: [PATCH 17/21] powerpc: Add missing prototype for sys_debug_setcontext

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-03-04 10:54:34
Also in: lkml

Mathieu Malaterre [off-list ref] writes:
In commit 81e7009ea46c ("powerpc: merge ppc signal.c and ppc64 signal32.c=
")
the function sys_debug_setcontext was added without a prototype.

Fix compilation warning (treated as error in W=3D1):

  CC      arch/powerpc/kernel/signal_32.o
arch/powerpc/kernel/signal_32.c:1227:5: error: no previous prototype for =
=E2=80=98sys_debug_setcontext=E2=80=99 [-Werror=3Dmissing-prototypes]
 int sys_debug_setcontext(struct ucontext __user *ctx,
     ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
This one should actually be using the SYSCALL_DEFINE syntax, so that it
can be used with CONFIG_FTRACE_SYSCALLS.

See eg. our mmap:

  SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
  		unsigned long, prot, unsigned long, flags,
  		unsigned long, fd, off_t, offset)
  {
  	return do_mmap2(addr, len, prot, flags, fd, offset, PAGE_SHIFT);
  }


We probably still need this patch, but I'm not entirely sure because the
SYSCALL_DEFINE macro does all sorts of shenanigans.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help