Re: [PATCH 01/21] powerpc: Remove warning on array size when empty

On Thu, Mar 1, 2018 at 3:55 AM, Michael Ellerman [off-list ref] wrote=
:

Mathieu Malaterre [off-list ref] writes:

quoted

When neither CONFIG_ALTIVEC, nor CONFIG_VSX or CONFIG_PPC64 is defined, =

the

quoted

array feature_properties is defined as an empty array, which in turn
triggers the following warning (treated as error on W=3D1):

  CC      arch/powerpc/kernel/prom.o
arch/powerpc/kernel/prom.c: In function =E2=80=98check_cpu_feature_prope=

rties=E2=80=99:

quoted

arch/powerpc/kernel/prom.c:298:16: error: comparison of unsigned express=

ion < 0 is always false [-Werror=3Dtype-limits]

g node)

 static void __init check_cpu_feature_properties(unsigned long node)
 {
-       unsigned long i;
        struct feature_property *fp =3D feature_properties;
        const __be32 *prop;
+       int i;

-       for (i =3D 0; i < ARRAY_SIZE(feature_properties); ++i, ++fp) {
+       for (i =3D 0; i < (int)ARRAY_SIZE(feature_properties); ++i, ++fp)=

 {

                prop =3D of_get_flat_dt_prop(node, fp->name, NULL);
                if (prop && be32_to_cpup(prop) >=3D fp->min_value) {
                        cur_cpu_spec->cpu_features |=3D fp->cpu_feature;

Indeed that looks like the less invasive solution, I'll re-submit.

Should I resubmit the entire patch series (21 indep patches) or
re-submit only the 3 patches that were discussed (as part of a
different series) ?

Thanks