Re: [RFC, 7/8] powerpc/xmon: Drop 'valid' from the condition inside 'dump_segments'

On Tue, 2015-07-21 at 17:15 +0530, Anshuman Khandual wrote:

On 07/21/2015 03:30 PM, Michael Ellerman wrote:

quoted

On Tue, 2015-21-07 at 06:58:45 UTC, Anshuman Khandual wrote:

quoted

quoted

From: "khandual@linux.vnet.ibm.com" <redacted>

Value of 'valid' is zero when 'esid' is zero and it does not matter
when 'esid' is non-zero. 

Yes it does. It tells you whether the entry is valid?

Yeah but it does not change the outcome of the if condition check
here. Non-zero esid will make the condition test pass irrespective
of the value of 'valid'. Yes, valid will be checked inside the code
block to print details, the point was value of valid does not make
any difference to the 'if' condition check in the first place.
Unless I am getting tricked here some how :)

No you're right, I was confused by the bitwise or.

Please make it:  if (esid || vsid)

And drop valid entirely, just do the check in the if condition.

And fix the change log:

  Hence the variable 'value'
                      ^
		      valid


cheers