Thread (50 messages) flat view 50 messages, 6 authors, 2014-10-02

Re: [PATCH v2 07/17] cxl: Add new header for call backs and structs

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-10-01 12:00:13
Also in: lkml

On Tue, 2014-30-09 at 10:34:56 UTC, Michael Neuling wrote:
From: Ian Munsie <redacted>

This new header add defines for callbacks and structs needed by the rest of the
                  adds
kernel to hook into the cxl infrastructure.

Empty functions are provided when CONFIG CXL_BASE is not enabled.

Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Michael Neuling <redacted>
---
 include/misc/cxl.h | 34 ++++++++++++++++++++++++++++++++++
include/misc is kind of weird. I guess it's a misc device.

Any reason not to have it in arch/powerpc/include ?
quoted hunk ↗ jump to hunk
diff --git a/include/misc/cxl.h b/include/misc/cxl.h
new file mode 100644
index 0000000..bde46a3
--- /dev/null
+++ b/include/misc/cxl.h
@@ -0,0 +1,34 @@
+/*
+ * Copyright 2014 IBM Corp.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+
+#ifndef _MISC_ASM_CXL_H
No ASM.
+#define _MISC_ASM_CXL_H
+
+#define CXL_IRQ_RANGES 4
+
+struct cxl_irq_ranges {
+	irq_hw_number_t offset[CXL_IRQ_RANGES];
+	irq_hw_number_t range[CXL_IRQ_RANGES];
+};
+
+#ifdef CONFIG_CXL_BASE
+
+void cxl_slbia(struct mm_struct *mm);
+void cxl_ctx_get(void);
+void cxl_ctx_put(void);
+bool cxl_ctx_in_use(void);
+
+#else /* CONFIG_CXL_BASE */
+
+#define cxl_slbia(...) do { } while (0)
+#define cxl_ctx_in_use(...) false
Any reason these shouldn't be static inlines?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help