Re: [PATCH v2 03/17] powerpc/cell: Make spu_flush_all_slbs() generic

On Wed, 2014-10-01 at 17:13 +1000, Michael Ellerman wrote:

On Tue, 2014-30-09 at 10:34:52 UTC, Michael Neuling wrote:

quoted

diff --git a/arch/powerpc/include/asm/copro.h b/arch/powerpc/include/as=

m/copro.h

quoted

index 2858108..f3d338f 100644

--- a/arch/powerpc/include/asm/copro.h
+++ b/arch/powerpc/include/asm/copro.h

@@ -15,4 +15,10 @@ int copro_handle_mm_fault(struct mm_struct *mm, unsi=

gned long ea,

quoted

=20
 int copro_data_segment(struct mm_struct *mm, u64 ea, u64 *esid, u64 *v=

sid);

quoted

=20
+
+#ifdef CONFIG_PPC_COPRO_BASE
+void copro_flush_all_slbs(struct mm_struct *mm);
+#else
+#define copro_flush_all_slbs(mm) do {} while(0)

=20
This can be a static inline, so it should be. That way you get type check=

ing on

the argument for CONFIG_PPC_COPRO_BASE=3Dn.

OK, I'll update.

Mikey