On Tue, Jul 22, 2014 at 11:10:42AM +0800, Mike Qiu wrote:

On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote:

quoted

On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote:

quoted

quoted

I don't like this. I much prefer have dedicated error injection files
in their respective locations, something for PCI under the corresponding
PCI bridge etc...

So PowerNV error injection will be designed rely on debugfs been
configured, right?

Not necessarily. If we create a better debugfs layout for our PHBs, then
yes. It might be useful to provide more info in there for example access
to some of the counters ...

But on the other hand, for error injection in general, I wonder if we should
be under sysfs instead... something to study a bit.

In pHyp, general error injection use syscall:

   #define __NR_rtas        255

I don't know if it is a good idea to reuse this syscall for PowerNV.

At least, it is another choice without sysfs rely.

We won't use syscall for routing the error injection on PowerNV any more.
Generally speaking, we will use ioctl commands or subcode of EEH ioctl
command, which was invented for EEH support for VFIO devices to suport
QEMU. For the utility (errinjct) running on PowerNV, we will use debugfs
entries. I have premature code for that, but don't have chance to polish
it yet. Let me send you that so that you can start working from there.

Thanks,
Gavin