Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-07-21 22:49:20
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-07-21 22:49:20
On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote:
quoted
I don't like this. I much prefer have dedicated error injection files in their respective locations, something for PCI under the corresponding PCI bridge etc...So PowerNV error injection will be designed rely on debugfs been configured, right?
Not necessarily. If we create a better debugfs layout for our PHBs, then yes. It might be useful to provide more info in there for example access to some of the counters ... But on the other hand, for error injection in general, I wonder if we should be under sysfs instead... something to study a bit. Cheers, Ben.