Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-06-25 03:19:21
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-06-25 03:19:21
On Wed, 2014-06-25 at 11:05 +0800, Mike Qiu wrote:
Here maybe "/sys/kernel/debug/powerpc/errinjct" is better, because it will supply "PCI_domain_nr" in parameters, so no need supply errinjct for each PCI domain. Another reason is error inject not only for PCI(in future), so better not in PCI domain entry. Also it simple for userland tools to has a fixed path.
I don't like this. I much prefer have dedicated error injection files in their respective locations, something for PCI under the corresponding PCI bridge etc... Cheers, Ben.