Thread (41 messages) 41 messages, 5 authors, 2014-02-27

Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters

From: Cody P Schafer <hidden>
Date: 2014-02-25 21:31:38
Also in: lkml

On 02/24/2014 07:33 PM, Michael Ellerman wrote:
On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote:
quoted
Signed-off-by: Cody P Schafer <redacted>
---
  arch/powerpc/perf/Makefile             | 2 ++
  arch/powerpc/platforms/Kconfig.cputype | 6 ++++++
  2 files changed, 8 insertions(+)
diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile
index 60d71ee..f9c083a 100644
--- a/arch/powerpc/perf/Makefile
+++ b/arch/powerpc/perf/Makefile
@@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS)	+= mpc7450-pmu.o
  obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o
  obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o

+obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o
+
  obj-$(CONFIG_PPC64)		+= $(obj64-y)
  obj-$(CONFIG_PPC32)		+= $(obj32-y)
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index 434fda3..dcc67cd 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -364,6 +364,12 @@ config PPC_PERF_CTRS
         help
           This enables the powerpc-specific perf_event back-end.

+config HV_PERF_CTRS
+       def_bool y
This was bool, why did you change it?
No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518
Maybe you're confusing v2.1 and v2 of this patch?
quoted
+       depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT
Should be:

	depends on PERF_EVENTS && PPC_PSERIES
quoted
+       help
+         Enable access to perf counters provided by the hypervisor
+
Yep, the v2.1 patch (which I bungled and labeled as 9/11) already 
changes both of these.
It'll end up rolled into v3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help