Thread (41 messages) 41 messages, 5 authors, 2014-02-27

Re: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-02-15 20:13:56
Also in: lkml

On Fri, Feb 14, 2014 at 02:02:07PM -0800, Cody P Schafer wrote:
bin_attributes created/updated in create_files() (such as those listed
via (struct device).attribute_groups) were not placed under the
specified group, and instead appeared in the base kobj directory.

Fix this by making bin_attributes use creating code similar to normal
attributes.

A quick grep shows that no one is using bin_attrs in a named attribute
group yet, so we can do this without breaking anything in usespace.

Note that I do not add is_visible() support to
bin_attributes, though that could be done as well.
is_visible() support would be nice to add if you get a chance.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help