Thread (41 messages) 41 messages, 5 authors, 2014-02-27

Re: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-02-25 03:33:32
Also in: lkml

On Fri, 2014-14-02 at 22:02:07 UTC, Cody P Schafer wrote:
bin_attributes created/updated in create_files() (such as those listed
via (struct device).attribute_groups) were not placed under the
specified group, and instead appeared in the base kobj directory.

Fix this by making bin_attributes use creating code similar to normal
attributes.

A quick grep shows that no one is using bin_attrs in a named attribute
group yet, so we can do this without breaking anything in usespace.

Note that I do not add is_visible() support to
bin_attributes, though that could be done as well.

Signed-off-by: Cody P Schafer <redacted>
Greg has already taken this, so we'll consider that as good as an ack from him,
unless he wants to give us one.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help