On 31.01.2013, at 15:56, Caraman Mihai Claudiu-B02008 wrote:

quoted

-----Original Message-----
From: Alexander Graf [mailto:agraf@suse.de]
Sent: Thursday, January 31, 2013 3:21 PM
To: Caraman Mihai Claudiu-B02008
Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org
Subject: Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register
initialization earlier
=20
=20
On 30.01.2013, at 14:29, Mihai Caraman wrote:
=20

quoted

VCPU's MMUCFG register initialization should not depend on

KVM_CAP_SW_TLB

quoted

ioctl call. Move it earlier into tlb initalization phase.

=20
Quite the contrary. The fact that there is an mfspr() in e500_mmu.c
already tells us that the code is broken. The TLB guest code should =

only

quoted

depend on input from the SW_TLB configuration. It's completely =

orthogonal

quoted

to the host capabilities.

=20
Then we have the same issue for TLBnCFG registers which need to be =

configured

via SW_TLB ioctl. What is the purpose of guest tlb initalization in =

e500_mmu.c

if we rely on SW_TLB?

It's to provide a fallback to user space that doesn't implement SW_TLB =
configuration yet.


Alex