RE: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier
From: Caraman Mihai Claudiu-B02008 <hidden>
Date: 2013-01-31 14:56:58
Also in:
kvm
From: Caraman Mihai Claudiu-B02008 <hidden>
Date: 2013-01-31 14:56:58
Also in:
kvm
-----Original Message----- From: Alexander Graf [mailto:agraf@suse.de] Sent: Thursday, January 31, 2013 3:21 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- dev@lists.ozlabs.org Subject: Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier =20 =20 On 30.01.2013, at 14:29, Mihai Caraman wrote: =20quoted
VCPU's MMUCFG register initialization should not depend onKVM_CAP_SW_TLBquoted
ioctl call. Move it earlier into tlb initalization phase.=20 Quite the contrary. The fact that there is an mfspr() in e500_mmu.c already tells us that the code is broken. The TLB guest code should only depend on input from the SW_TLB configuration. It's completely orthogonal to the host capabilities.
Then we have the same issue for TLBnCFG registers which need to be configur= ed via SW_TLB ioctl. What is the purpose of guest tlb initalization in e500_mm= u.c if we rely on SW_TLB? -Mike