Re: [PATCH V7 2/3] powerpc/ge_imp3a: Add ISA node to PCI primary bus

On Aug 15, 2012, at 12:31 PM, Scott Wood wrote:

On 08/15/2012 03:57 AM, Jia Hongtao wrote:

quoted

PCI primary bus will be determined by looking for ISA node in device =

tree.

quoted

Also for board ge_imp3a primary bus is the second PCI controller =

detected.

quoted

So we add ISA node to ge_imp3a's device tree to fit the new =

determination.

quoted

=20
Adding ISA node to other boards' device tree is not necessary. The =

situation

quoted

that the first bus is primary have already been handled. Please refer =

to the

quoted

following patch:
powerpc/pci: Make sure ISA IO base is not zero
=20
Signed-off-by: Jia Hongtao <redacted>
Signed-off-by: Li Yang <redacted>
---
arch/powerpc/boot/dts/ge_imp3a.dts |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
=20

diff --git a/arch/powerpc/boot/dts/ge_imp3a.dts =

b/arch/powerpc/boot/dts/ge_imp3a.dts

quoted

index fefae41..aa2c4b5 100644

--- a/arch/powerpc/boot/dts/ge_imp3a.dts
+++ b/arch/powerpc/boot/dts/ge_imp3a.dts

@@ -248,6 +248,10 @@

				  0x1000000 0x0 0x0
				  0x1000000 0x0 0x0
				  0x0 0x10000>;
+
+			isa@1e {
+				device_type =3D "isa";
+			};
		};
	};
};

=20
I believe I already said it's not acceptable to break old device =

trees.

=20
-Scott
=20

I agree w/Scott this is NOT an acceptable solution, both because of old =
device tree and its just wrong to list ISA if it doesn't exist in the =
device.

- k=