Thread (47 messages) 47 messages, 4 authors, 2012-07-24

Re: [PATCH -V3 04/11] arch/powerpc: Rename va to vpn

From: Aneesh Kumar K.V <hidden>
Date: 2012-07-23 06:15:02

Paul Mackerras [off-list ref] writes:
On Mon, Jul 09, 2012 at 06:43:34PM +0530, Aneesh Kumar K.V wrote:
quoted
From: "Aneesh Kumar K.V" <redacted>

Rename the variable to better reflect the values. No functional change
in this patch.

Signed-off-by: Aneesh Kumar K.V <redacted>
I think you missed a couple: kernel_map_linear_page and
kernel_unmap_linear_page are now broken since you change va to vpn in
the declaration but not in the uses, and you change host_va to
host_vpn in struct hpte_cache but don't fix up the use in
kvmppc_mmu_invalidate_pte.
Will fix.
 How many configs did you compile-test this
with?
Not much. I will try to do a test build of multiple configs.

Thanks
-aneesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help