Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

On Wed, Mar 7, 2012 at 11:51 PM, Russell King - ARM Linux
[off-list ref] wrote:

On Wed, Mar 07, 2012 at 11:39:25PM +0530, Jassi Brar wrote:

quoted

Compilation is broken without the following minor fix.
After that you may add
=C2=A0 =C2=A0 =C2=A0 =C2=A0Acked-by: Jassi Brar <jassisinghbrar@gmail.co=

m>

quoted

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 49c123f..abf35a3 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c

@@ -339,7 +339,6 @@ static int pl330_control(struct dma_chan *chan,

enum dma_ctrl_cmd cmd, unsigned
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Mark all desc done *=

/

quoted

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 list_for_each_entry_saf=

e(desc, _dt, &pch->work_list , node) {

quoted

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =

=C2=A0 desc->status =3D DONE;

quoted

- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =

pch->completed =3D desc->txd.cookie;

I'm not sure just removing this is sufficient. =C2=A0Presumably it's
there for some reason - maybe it needs replacing with a call to
dma_cookie_complete() to preserve existing behaviour?

That was anyway a redundant save in DMA_TERMINATE_ALL, so it should be ok.