Thread (31 messages) 31 messages, 9 authors, 2012-04-23

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

flat view
STALE5282d

From: Russell King - ARM Linux <hidden>
Date: 2012-03-07 18:21:55
Also in: linux-arm-kernel

Revision v2 of 8 in this series.

Revisions (8)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v2
  5. v2
  6. v2 current
  7. v2
  8. v2 
On Wed, Mar 07, 2012 at 11:39:25PM +0530, Jassi Brar wrote:
quoted hunk ↗ jump to hunk
Compilation is broken without the following minor fix.
After that you may add
       Acked-by: Jassi Brar [off-list ref]

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 49c123f..abf35a3 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -339,7 +339,6 @@ static int pl330_control(struct dma_chan *chan,
enum dma_ctrl_cmd cmd, unsigned
 		/* Mark all desc done */
 		list_for_each_entry_safe(desc, _dt, &pch->work_list , node) {
 			desc->status = DONE;
-			pch->completed = desc->txd.cookie;
I'm not sure just removing this is sufficient.  Presumably it's
there for some reason - maybe it needs replacing with a call to
dma_cookie_complete() to preserve existing behaviour?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help