Re: [PATCH] net: xilinx_emaclite: Fix problem with first incoming packet
From: Grant Likely <hidden>
Date: 2009-09-22 16:54:05
Also in:
netdev
On Tue, Sep 22, 2009 at 8:24 AM, John Linn [off-list ref] wrote:
From: Michal Simek <monstr@monstr.eu> You can't ping the board or connect to it unless you send any packet out from board. Tested-by: John Williams <redacted> Signed-off-by: Michal Simek <monstr@monstr.eu> Acked-by: John Linn <redacted>
John, Since this patch is being *sent* by you, then you should use a "signed-off-by" tag instead because it actually passed through your hands. Oh, and: Acked-by: Grant Likely <redacted>
quoted hunk ↗ jump to hunk
--- =A0drivers/net/xilinx_emaclite.c | =A0 =A07 ++----- =A01 files changed, 2 insertions(+), 5 deletions(-)diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.=
c
quoted hunk ↗ jump to hunk
index dc22782..83a044d 100644--- a/drivers/net/xilinx_emaclite.c +++ b/drivers/net/xilinx_emaclite.c@@ -134,18 +134,15 @@ static void xemaclite_enable_interrupts(struct net_=
local *drvdata)
=A0 =A0 =A0 =A0}
=A0 =A0 =A0 =A0/* Enable the Rx interrupts for the first buffer */
- =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr + XEL_RSR_OFFSET);
=A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_RSR_OFFSET,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_RECV_IE_MASK);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK);
=A0 =A0 =A0 =A0/* Enable the Rx interrupts for the second Buffer if
=A0 =A0 =A0 =A0 * configured in HW */
=A0 =A0 =A0 =A0if (drvdata->rx_ping_pong !=3D 0) {
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr + X=EL_BUFFER_OFFSET +
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_=
RSR_OFFSET);
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_BUFFER_O=
FFSET +
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 XEL_RSR_OFFSET, - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_RECV_=
IE_MASK);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK); =A0 =A0 =A0 =A0} =A0 =A0 =A0 =A0/* Enable the Global Interrupt Enable */ -- 1.6.2.1 This email and any attachments are intended for the sole use of the named=
recipient(s) and contain(s) confidential information that may be proprieta= ry, privileged or copyrighted under applicable law. If you are not the inte= nded recipient, do not read, copy, or forward this email message or any att= achments. Delete this email message and any attachments immediately.
--=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.