Thanks Grant, I wondered about that myself.

-----Original Message-----
From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Gra=

nt Likely

Sent: Tuesday, September 22, 2009 10:54 AM
To: John Linn
Cc: netdev@vger.kernel.org; davem@davemloft.net; linuxppc-dev@ozlabs.org;=

 jwboyer@linux.vnet.ibm.com;

Sadanand Mutyala; Michal Simek
Subject: Re: [PATCH] net: xilinx_emaclite: Fix problem with first incomin=

g packet

=

On Tue, Sep 22, 2009 at 8:24 AM, John Linn [off-list ref] wrote:

quoted

From: Michal Simek <monstr@monstr.eu>

You can't ping the board or connect to it unless you send
any packet out from board.

Tested-by: John Williams <redacted>
Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: John Linn <redacted>

=

John, Since this patch is being *sent* by you, then you should use a
"signed-off-by" tag instead because it actually passed through your
hands.
=

Oh, and:
Acked-by: Grant Likely <redacted>
=

quoted

---
=A0drivers/net/xilinx_emaclite.c | =A0 =A07 ++-----
=A01 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclit=

e.c

quoted

index dc22782..83a044d 100644

--- a/drivers/net/xilinx_emaclite.c
+++ b/drivers/net/xilinx_emaclite.c

@@ -134,18 +134,15 @@ static void xemaclite_enable_interrupts(struct ne=

t_local *drvdata)

quoted

=A0 =A0 =A0 =A0}

=A0 =A0 =A0 =A0/* Enable the Rx interrupts for the first buffer */
- =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr + XEL_RSR_OFFSET)=

;

quoted

=A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_RSR_OFFSET,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_RECV_IE_MASK);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK);

=A0 =A0 =A0 =A0/* Enable the Rx interrupts for the second Buffer if
=A0 =A0 =A0 =A0 * configured in HW */
=A0 =A0 =A0 =A0if (drvdata->rx_ping_pong !=3D 0) {
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr +=

 XEL_BUFFER_OFFSET +

quoted

- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XE=

L_RSR_OFFSET);

quoted

=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_BUFFER=

_OFFSET +

quoted

=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 XEL_RSR_OFFSET,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_REC=

V_IE_MASK);

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK);=

quoted

=A0 =A0 =A0 =A0}

=A0 =A0 =A0 =A0/* Enable the Global Interrupt Enable */
--
1.6.2.1



This email and any attachments are intended for the sole use of the nam=

ed recipient(s) and

contain(s) confidential information that may be proprietary, privileged o=

r copyrighted under

applicable law. If you are not the intended recipient, do not read, copy,=

 or forward this email

message or any attachments. Delete this email message and any attachments=

 immediately.

quoted

=

=

=

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.