Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika
From: Jon Smirl <hidden>
Date: 2009-05-28 18:58:27
Also in:
alsa-devel
On Thu, May 28, 2009 at 10:00 AM, Peter Korsgaard [off-list ref] wrote= :
quoted
quoted
quoted
quoted
quoted
"Jon" =3D=3D Jon Smirl [off-list ref] writes:Hi, =A0Jon> Fabric bindings for STAC9766 AC97 codec on the Efika. =A0Jon> Signed-off-by: Jon Smirl [off-list ref] =A0Jon> --- =A0Jon> =A0sound/soc/fsl/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A08 ++=
+
=A0Jon> =A0sound/soc/fsl/Makefile =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01 =A0Jon> =A0sound/soc/fsl/efika-audio-fabric.c | =A0 95 ++++++++++++++++++=
++++++++++++++++++
=A0Jon> =A03 files changed, 104 insertions(+), 0 deletions(-) =A0Jon> =A0create mode 100644 sound/soc/fsl/efika-audio-fabric.c =A0Jon> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig =A0Jon> index 79579ae..f571c6e 100644 =A0Jon> --- a/sound/soc/fsl/Kconfig =A0Jon> +++ b/sound/soc/fsl/Kconfig =A0Jon> @@ -47,3 +47,11 @@ config SND_MPC52xx_SOC_PCM030 =A0Jon> =A0 help =A0Jon> =A0 =A0 Say Y if you want to add support for sound on the Phytec =
pcm030 baseboard.
=A0Jon> +config SND_MPC52xx_SOC_EFIKA =A0Jon> + tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" =A0Jon> + depends on PPC_EFIKA =A0Jon> + select SND_SOC_MPC5200_AC97 =A0Jon> + select SND_SOC_STAC9766 =A0Jon> + help =A0Jon> + =A0 Say Y if you want to add support for sound on the Efika. =A0Jon> + Wouldn't it make more sense to make this default y when it has such specific dependencies and is so deep down in the tree - Most efika users probably want to enable this if they have enabled ALSA and SND_SOC?
I can change it in the next round of updates. Right now I'd like to get some people testing it and maybe doing some patches to enhance it. For example I know he code has a problem where about 5% of the time the codec doesn't reset right on boot. Someone needs to put an oscilloscope on the codec chip and tell me why it is failing.
-- Bye, Peter Korsgaard
--=20 Jon Smirl jonsmirl@gmail.com