On Mon, May 25, 2009 at 6:26 AM, Mark Brown
[off-list ref] wrote:

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 spin_lock(&psc_dma->lock);
+ =A0 =A0 =A0 =A0 =A0 =A0 out_be32(&psc_dma->psc_regs->ac97_slots, psc_d=

ma->slots);

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock(&psc_dma->lock);
+ =A0 =A0 =A0 =A0 =A0 =A0 break;

This locking looks wrong - I'd expect it to also cover the modification
of psc_dma->slots? =A0Otherwise it's hard to see what it buys you.

Grant, why are you spin locking around register access?


--=20
Jon Smirl
jonsmirl@gmail.com