Thread (22 messages) 22 messages, 4 authors, 2009-05-28

Re: [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

From: Jon Smirl <hidden>
Date: 2009-05-25 14:39:30
Also in: alsa-devel

On Mon, May 25, 2009 at 2:34 AM, Grant Likely [off-list ref] w=
rote:
On Sun, May 24, 2009 at 7:38 PM, Jon Smirl [off-list ref] wrote:

This is ugly. =A0I'd really rather have a generic mechanism for creating
a fabric driver based on the OF data. =A0But failing that, it seems to
me that this platform device registration should be done in the
platform code (arch/powerpc/platforms/52xx). =A0Doing it in a module
init looks wrong.
I'm all for deleting it as soon as AC97 is capable of auto-loading.  I
thought it was better to leave it in the sound directories to keep it
isolated since the intention is to remove it when possible.

BTW, my binding files are quite simple compared to mpc8610_hpcd.c.

I was trying to do a sort of generic matching mechanism with the of
simple stuff; but admittedly it was hacky and half-assed. =A0However, I
do still think it is viable to have OF hooks that kick in when codec
and machine drivers are registered. =A0If linkage data is encoded in the
device tree, then generic code should be able to hook them up; pulling
additional data out of the device tree as needed to configure the
coded.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


--=20
Jon Smirl
jonsmirl@gmail.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help