Re: [PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)

On Sun, Mar 1, 2009 at 8:54 AM, Jon Smirl [off-list ref] wrote:

On Sun, Mar 1, 2009 at 9:48 AM, Grant Likely [off-list ref] =

wrote:

quoted

On Sun, Mar 1, 2009 at 3:18 AM, Wolfram Sang [off-list ref] wro=

te:

quoted

quoted

Hi Grant,

thanks for the review!

On Thu, Feb 26, 2009 at 10:31:24PM -0700, Grant Likely wrote:

quoted

Thanks for the patch Wolfram. =A0Comments below.

On Wed, Feb 25, 2009 at 8:32 AM, Wolfram Sang [off-list ref] =

wrote:

quoted

quoted

quoted

quoted

Signed-off-by: Wolfram Sang <redacted>
---
=A0arch/powerpc/boot/dts/pcm032.dts =A0 =A0 =A0 =A0 =A0 =A0 | =A0391=

 +++++++

quoted

quoted

quoted

quoted

=A0arch/powerpc/configs/52xx/pcm032_defconfig =A0 | 1394 +++++++++++=

+++++++++++++++

quoted

quoted

quoted

Do you really need a separate defconfig for this board? =A0Can it be
merged with an existing defconfig?

Will have a look if I can make a pcm03x_defconfig out of pcm030_defconf=

ig.

quoted

Cool, thanks.

quoted

quoted

motionpro.dts is a good example of what it should look like.

Ah, thanks for the pointer. Will have a look there. Guess I'll need to =

update

quoted

quoted

pcm030.dts later, too (from which I copied this one). Will rewrite the
localbus-node addressing the comments you gave.

pcm030.dts in mainline doesn't have a localbus node.

I've been using this on my pcm030 locally.

Hey Jon, a few comments below for the record.  :-)

pcm030 doesn't have a PCI socket but it can be added via the expansion bu=

s.

With just the basic pcm030 hardware, if I uncomment the pci node I
sometimes hang on boot.

Hmmm.  Weird.  Have you been able to identify what code it hangs in?

=A0 =A0 =A0 =A0lpb@ff000000 {

This node doesn't really have an address since it is simply a bus (the
control registers are elsewhere).  Should make this simply: locabus {

=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0compatible =3D "fsl,lpb", "simple-bus";

Ideally this should be: compatible =3D
"fsl,mpc5200b-lpb",fsl,mpc5200-lpb","simple-bus".  However, I forgot
to add "simple-bus" to arch/powerpc/platforms/52xx/mpc52xx-common.c
for the bus probing code and so this won't work in current mainline.
The fix is queued up in -next, and I'm going to try and get it into
.29

Cheers,
g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.