Re: [PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)

Hi Grant,

thanks for the review!

On Thu, Feb 26, 2009 at 10:31:24PM -0700, Grant Likely wrote:

Thanks for the patch Wolfram.  Comments below.

On Wed, Feb 25, 2009 at 8:32 AM, Wolfram Sang [off-list ref] wrote:

quoted

Signed-off-by: Wolfram Sang <redacted>
---
 arch/powerpc/boot/dts/pcm032.dts             |  391 +++++++
 arch/powerpc/configs/52xx/pcm032_defconfig   | 1394 ++++++++++++++++++++++++++

Do you really need a separate defconfig for this board?  Can it be
merged with an existing defconfig?

Will have a look if I can make a pcm03x_defconfig out of pcm030_defconfig.

motionpro.dts is a good example of what it should look like.

Ah, thanks for the pointer. Will have a look there. Guess I'll need to update
pcm030.dts later, too (from which I copied this one). Will rewrite the
localbus-node addressing the comments you gave.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |