Thread (39 messages) 39 messages, 6 authors, 2008-04-12

Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

From: Josh Boyer <hidden>
Date: 2008-03-26 12:39:06

On Tue, 25 Mar 2008 10:21:53 +1100
Benjamin Herrenschmidt [off-list ref] wrote:
On Thu, 2008-03-06 at 16:41 +0300, Valentine Barshak wrote:
quoted
The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error)
if there's no link. Because of that it fails to find PHY chip. The older ibm_emac
driver had a workaround for that: the EMAC_CLK_INTERNAL/EMAC_CLK_EXTERNAL macros,
which toggle the Ethernet Clock Select bit in the SDR0_MFR register. This patch
does the same for "ibm,emac-440gx" compatible chips. The workaround forces
clock on -all- EMACs, so we select clock under global emac_phy_map_lock.

Signed-off-by: Valentine Barshak <redacted>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Just get them acked by Jeff now and they can go in via Josh tree.
This never went to netdev or Jeff from what I can see.

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help