Re: [i2c] [PATCH] Make i2c-mpc driver use i2c_add_numbered_adapter

On 5/15/07, David Brownell [off-list ref] wrote:

On Tuesday 15 May 2007, Jean Delvare wrote:

quoted

On Mon, 14 May 2007 13:11:23 -0600, Grant Likely wrote:

quoted

quoted

--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c

@@ -327,9 +327,10 @@ static int fsl_i2c_probe(struct platform_device *pdev)
    platform_set_drvdata(pdev, i2c);

    i2c->adap = mpc_ops;
+   i2c->adap.nr = pdev->id;

By the way:  mpc_ops is a static i2c_adapter, so given that
the reason for using pdev->id that way was that there might
be more than one such platform device ... shouldn't allocation
of the adapter be moved into allocation of the "i2c->" object?

Take another look; this is a funny quirk of the driver.  The
assignment is 'i2c->adap = mpc_ops'; not 'i2c->adap = &mpc_ops'.  And
in struct mpc_i2c, the field is declared as 'struct i2c_adapter adap',
not 'struct i2c_adapter *adap'.  The driver instance gets a copy of
the mpc_ops structure to initialize it, not a pointer to the staticly
defined structure.  I got bitten by the same thing when I was looking
at the code.

Not to mention that mpc_ops is poorly named.

Cheers,
g.


-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195