Re: [PATCH] powerpc: Fix warning in pci_64.c

On Tue, 2007-05-15 at 14:30 +1000, Stephen Rothwell wrote:

On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt [off-list ref] wrote:

quoted

 void pcibios_add_platform_entries(struct pci_dev *pdev)
 {
-	device_create_file(&pdev->dev, &dev_attr_devspec);
+	int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
+	WARN_ON(rc != 0);

If we really don't care if the file is not created, then it is probably
worth a comment as to why ...

Well, if it's not created, then something is badly wrong thus a
WARN_ON ... Do you think I should do more ?

Ben.