Re: [PATCH] powerpc: Fix warning in pci_64.c

On Tue, 2007-05-15 at 14:30 +1000, Stephen Rothwell wrote:

On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt [off-list ref] wrote:

quoted

 void pcibios_add_platform_entries(struct pci_dev *pdev)
 {
-	device_create_file(&pdev->dev, &dev_attr_devspec);
+	int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
+	WARN_ON(rc != 0);

If we really don't care if the file is not created, then it is probably
worth a comment as to why ...

Greg already has a patch from me to fix that.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person