Re: [PATCH] powerpc: Fix warning in pci_64.c
From: Stephen Rothwell <hidden>
Date: 2007-05-15 04:30:53
On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt [off-list ref] wrote:
void pcibios_add_platform_entries(struct pci_dev *pdev)
{
- device_create_file(&pdev->dev, &dev_attr_devspec);
+ int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
+ WARN_ON(rc != 0);If we really don't care if the file is not created, then it is probably worth a comment as to why ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Attachments
- (unnamed) [application/pgp-signature] 189 bytes