Re: [PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes.

Kumar Gala wrote:

On May 7, 2007, at 4:51 PM, Andy Fleming wrote:

quoted

Yeah, I just read that.  You should either make that more explicit in
the documentation, or make it generic.  It's fine if there are
drivers/devices that don't need to be told or tell anyone that they
recognize magic packets for them to work.  The lack of the property
in other controllers won't break anything.

But I'm fine if you just document that the bit indicates,
specifically, the presence of magic-packet bits in certain registers
on the eTSEC.

I'd ask is it really freescale specific?  In that I'd assume its  
support for the standard wake-on-lan packet.

It is the standard wake-on-lan packet, but the intent of the property is 
not to advertise to the entire system that this device supports it, but 
rather to indicate that the MPEN bit and the like are valid for the 
driver to use.  Making it standard means that someone might use it for 
other purposes, such as pm config tools digging around in 
/proc/device-tree (sure, they could just use ethtool -- but they might 
not), which would mean that all magic-packet-capable devices (gianfar or 
not) would need the property.

If we want to do that, fine -- but that change is at a different scope 
than the one I made.

-Scott