Re: [PATCH 12/13] gianfar: Add flags for magic packet and MDIO.
From: Andy Fleming <hidden>
Date: 2007-05-07 21:45:51
quoted hunk ↗ jump to hunk
@@ -323,6 +326,10 @@ static int __init gfar_of_init(void) gfar_data.phy_id = *id; gfar_data.bus_id = res.start; + if (res.start >= gfar_dev->resource[0].start && + res.start < gfar_dev->resource[0].end) + gfar_data.device_flags |= FSL_GIANFAR_DEV_HAS_MDIO; +
Hrm. I don't think this is a good way to go. The DEV* flags are all features right now, rather than configuration settings. It seems like this is a stop-gap solution for until more robust detection of the ability to power down the interface. I can understand that a full solution might be beyond the ambitions of this first set of patches, but I'd prefer if we didn't pollute gianfar's device flags space with a flag that we should aim at removing eventually. Andy