Thread (42 messages) 42 messages, 5 authors, 2007-02-15

Re: [PATCH 05/12] power management: no valid states w/o pm_ops + docs

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-02-13 16:08:40
Also in: linux-pm

On Tue, 2007-02-13 at 13:12 +0100, Pavel Machek wrote:
Hi!
quoted
This patch changes /sys/power/state to not advertise any valid states
(except for disk if SOFTWARE_SUSPEND is enabled) when no pm_ops have been
set so userspace can easily discover what states should be available.

Also, because the pm ops in powermac are obviously not using them as
intended, I added documentation for it in kernel-doc format.

Reordering the fields in struct pm_ops not only makes the output of
kernel-doc make more sense but also removes a hole from the structure on
64-bit platforms.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-pm@lists.osdl.org
Cc: Rafael J. Wysocki <redacted>
Cc: Pavel Macheck <redacted>
Looks okay to me.
Are you going to pick it up or should I send it to someone else?

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help