Re: [PATCH 05/12] power management: no valid states w/o pm_ops + docs
From: Pavel Machek <hidden>
Date: 2007-02-13 12:12:49
Also in:
linux-pm
From: Pavel Machek <hidden>
Date: 2007-02-13 12:12:49
Also in:
linux-pm
Hi!
This patch changes /sys/power/state to not advertise any valid states (except for disk if SOFTWARE_SUSPEND is enabled) when no pm_ops have been set so userspace can easily discover what states should be available. Also, because the pm ops in powermac are obviously not using them as intended, I added documentation for it in kernel-doc format. Reordering the fields in struct pm_ops not only makes the output of kernel-doc make more sense but also removes a hole from the structure on 64-bit platforms. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Cc: linux-pm@lists.osdl.org Cc: Rafael J. Wysocki <redacted> Cc: Pavel Macheck <redacted>
Looks okay to me. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html