On Thu, 2007-02-08 at 14:28 +0100, Johannes Berg wrote:

+#ifdef CONFIG_CPU_HOTPLUG
+       /* if we have fake CPU hotplug just to support suspend to disk
+        * and can't really turn off a CPU, it may be taking timer interrupts
+        * even when it is dead. Avoid doing anything in that case so global
+        * state is not modified for and by a CPU that doesn't really exist. */
+       if (__get_cpu_var(cpu_state) == CPU_DEAD)
+               return;
+#endif

Michael Buesch suggested to add an unlikely() there which I'll do for
the next round.

johannes