Re: [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE

On Fri, 2007-01-26 at 04:14 +0100, Christoph Hellwig wrote:

On Thu, Jan 25, 2007 at 06:51:50PM +0100, Geert Uytterhoeven wrote:

quoted

PS3: Cleanup the frame buffer device before clearing the HPTE mapping

Signed-off-by: Geert Uytterhoeven <redacted>
---
 arch/powerpc/platforms/ps3/htab.c |    5 +++++
 1 files changed, 5 insertions(+)

--- ps3-linux.orig/arch/powerpc/platforms/ps3/htab.c
+++ ps3-linux/arch/powerpc/platforms/ps3/htab.c

@@ -234,6 +234,11 @@ static void ps3_hpte_invalidate(unsigned
 
 static void ps3_hpte_clear(void)
 {
+	extern void ps3fb_cleanup(void);

Externs belong into headers.

quoted

+
+#ifdef CONFIG_FB_PS3
+	ps3fb_cleanup();
+#endif

And when you move it into a header, create a dummy version so you can
remove the #ifdef in the C code. eg:

#ifdef CONFIG_FB_PS3
extern void ps3fb_cleanup(void);
#else
static inline void ps3fb_cleanup(void) { };
#endif

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person