Re: [PATCH 1/9] ps3: AV Settings Driver

On Fri, 26 Jan 2007, Arnd Bergmann wrote:

On Thursday 25 January 2007 18:48, Geert Uytterhoeven wrote:

quoted

+#ifdef PS3AV_DEBUG
+#define DPRINTK(fmt, args...) \
+	do { printk("ps3av " fmt, ## args); } while (0)
+#else
+#define DPRINTK(fmt, args...) do { } while (0)
+#endif

You should probably use the provided pr_debug or (better) dev_dbg
macros to do that now.

Except that it's difficult to get a struct device * in drivers/ps3/ps3av_cmd.c.
And I prefer not to make ps3av_dev (which is currently static) global.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium