quoted

+static int __devexit ipmi_of_remove(struct of_device *dev)
+{
+	/* should call
+	 * cleanup_one_si(dev->dev.driver_data); */
+	return 0;
+}

If your remove doesn't work, don't implement one.

As explained before, it's the underlying thing that doesn't
work.  Yeah someone should fix it one day.  Still it's better
to have this comment than to not have anything at all.  An
XXX FIXME: tag wouldn't be out of place of course.

Though since you don't
have the choice in having a module_exit or not, you should really
implement one that works :-)

Genau.


Segher