Segher Boessenkool wrote:

quoted

quoted

quoted

+static int ipmi_of_remove(struct of_device *dev)
+{
+     /* should call
+      * cleanup_one_si(dev->dev.driver_data); */
        

So fix that :-)
      

That should be a separate patch that fixes the same thing for
pci ipmi devices as well. It needs to move code around for this
(or introduce forward declarations), and the effect is no
different, so it's really just a cleanup.
    

Oh, this is broken in the existing stuff as well?  Never mind then.
  

The forward declaration (and changes required for this to work) is in 
Linus' current tree, but was not released in 2.6.19.  So a later patch 
should be fine.

-Corey