Thread (25 messages) 25 messages, 6 authors, 2007-01-29

Re: [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree

From: Christian Krafft <hidden>
Date: 2006-12-19 13:16:59

On Mon, 18 Dec 2006 22:52:07 +0100
Segher Boessenkool [off-list ref] wrote:

=20
info->io_regsize =3D regsize ? *regsize : DEFAULT_REGSIZE;
=20
[Please note that fixes a copy/paste bug, too].
There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING as th=
e default size.
It looks like the code assumes that the registers are located next to each =
other.
If thats not good, DEFAULT_REGSIZE should be introduced and used in all oth=
er probe functions as well.
That would be a seperate issue .
=20
=20
Segher
=20

--=20
Mit freundlichen Gr=FCssen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,=20
Linux Kernel Development
IT Specialist
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help