Thread (6 messages) 6 messages, 3 authors, 2006-12-20

Re: [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-12-20 00:19:54

On Tue, 2006-12-19 at 18:10 -0600, Scott Wood wrote:
Benjamin Herrenschmidt wrote:
quoted
What cores do those chip use ? Any reason why one couldn't build a
kernel that boots those chips -and- chrp,pmac,etc... in one image ?

If that is the case, then your initcall will incorrectly be called on
platforms that don't need it.
It won't do anything, though, unless it finds a node that matches 
of_default_bus_ids.  Are there any platforms on which "soc" nodes (or 
others in the default list) shouldn't be probed?  If not, perhaps make a 
generic initcall to of_platform_bus_probe(), so that it won't be called 
multiple times by different SoC types that are in the same kernel?
There is none right now that shouldn't be probed but I haven't been too
happy about having a default list in the first place (despite me writing
that code :-)
Otherwise, perhaps the SoCs could be given "fsl-soc" in their compatible 
field, and have fsl_publish_devices() pass that as a match struct.
Might be a better option.

I'd rather keep things well separate for now.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help