Re: [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs
From: Scott Wood <hidden>
Date: 2006-12-20 00:10:20
From: Scott Wood <hidden>
Date: 2006-12-20 00:10:20
Benjamin Herrenschmidt wrote:
What cores do those chip use ? Any reason why one couldn't build a kernel that boots those chips -and- chrp,pmac,etc... in one image ? If that is the case, then your initcall will incorrectly be called on platforms that don't need it.
It won't do anything, though, unless it finds a node that matches of_default_bus_ids. Are there any platforms on which "soc" nodes (or others in the default list) shouldn't be probed? If not, perhaps make a generic initcall to of_platform_bus_probe(), so that it won't be called multiple times by different SoC types that are in the same kernel? Otherwise, perhaps the SoCs could be given "fsl-soc" in their compatible field, and have fsl_publish_devices() pass that as a match struct.
I think what we need to do is to define a mecanism for board initcalls. Something like board_xxx_initcall(boardname, function);
It's not really a board-level issue, though -- at most, it's SoC-level. -Scott