Thread (6 messages) 6 messages, 3 authors, 2006-12-20

Re: [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-12-19 23:40:36

it's not characteristic of FSL _boards_ per se.  It's characteristic of FSL
powerpc SoC chips, and it resides in a file that will only be built for that
case.  This is a legitimate way to support multiple platforms in a single
image without incurring multiple device_initcall()s with the same parameter.
I didn't see an appropriate ppc_md. function to use; are you suggesting we add
one just for this?  wouldn't that be fsl specific also, but reside in common code?
What cores do those chip use ? Any reason why one couldn't build a
kernel that boots those chips -and- chrp,pmac,etc... in one image ?

If that is the case, then your initcall will incorrectly be called on
platforms that don't need it.

I think what we need to do is to define a mecanism for board initcalls.

Something like board_xxx_initcall(boardname, function);

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help