Re: [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc
From: Kumar Gala <hidden>
Date: 2006-10-31 14:34:46
From: Kumar Gala <hidden>
Date: 2006-10-31 14:34:46
On Oct 31, 2006, at 2:42 AM, Benjamin Herrenschmidt wrote:
On Tue, 2006-10-31 at 09:25 +0100, Nicolas DET wrote:quoted
Ok. By the way, the mbar is include as property in our OpenFrimware. Moreover, the G2CORE CPU has a new SPR 'MBAR' which is the MBAR ;-). It would maybe make sense to create a new file (arch/powerpc/sysdev/mpc52xx.c) which would contain chip specific code. Like mpc52xx_get_mbar(), mpc52xx_get_ipbfreq(), etc... I updated a bit the patches. I applied Dale requests. My kernel still compiles and boots. ;-) Should I post the new patches?Sure.quoted
About the headers thingy. Should I split them directly in the patch, or this should be done by others later on?Don't bother that much about splitting the headers. I personally don't mind.
I think we should at least split out the interrupt stuff into a arch/ powerpc/sysdev/mpc52xx_pic.h, but we can make the change in the future. - k